Skip to content

Fix the model summary table#50

Merged
jemrobinson merged 4 commits intomainfrom
fix-model-summary-table
Aug 8, 2025
Merged

Fix the model summary table#50
jemrobinson merged 4 commits intomainfrom
fix-model-summary-table

Conversation

@jemrobinson
Copy link
Copy Markdown
Member

@jemrobinson jemrobinson commented Aug 7, 2025 •
edited
Loading

Change the model summary table from:

  | Name       | Type                    | Params | Mode
---------------------------------------------------------------
0 | model_list | ModuleList              | 11.0 M | train
1 | processor  | UNetProcessor           | 11.0 M | train
2 | decoder    | NaiveLatentSpaceDecoder | 4.0 K  | train
---------------------------------------------------------------

to the more accurate:

  | Name      | Type                    | Params | Mode
--------------------------------------------------------------
0 | encoder_0 | NaiveLatentSpaceEncoder | 337 K  | train
1 | processor | UNetProcessor           | 11.0 M | train
2 | decoder   | NaiveLatentSpaceDecoder | 4.0 K  | train
--------------------------------------------------------------

@jemrobinson jemrobinson force-pushed the fix-model-summary-table branch from ffce0fc to ec76c39 Compare August 7, 2025 15:58
@jemrobinson jemrobinson requested review from a team and IFenton August 7, 2025 16:07
IFenton
IFenton requested changes Aug 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@IFenton IFenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, except for the mypy test failure. The encoders don't seem to be converting to pytorch Modules

Comment thread ice_station_zebra/models/encode_process_decode.py Outdated
@jemrobinson jemrobinson changed the title Fix the model summary table [WIP] Fix the model summary table Aug 8, 2025
@jemrobinson jemrobinson marked this pull request as draft August 8, 2025 09:52
@jemrobinson jemrobinson marked this pull request as ready for review August 8, 2025 09:52
@jemrobinson jemrobinson changed the title [WIP] Fix the model summary table Fix the model summary table Aug 8, 2025
@jemrobinson
Copy link
Copy Markdown
Member Author

jemrobinson commented Aug 8, 2025

This looks fine, except for the mypy test failure. The encoders don't seem to be converting to pytorch Modules

This is because the variable name encoder was shadowing one of the arguments to the function also called encoder.

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Aug 8, 2025

Coverage report

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)		Lines missing
  ice_station_zebra/models
  encode_process_decode.py 37-41
  zebra_model.py 28-32, 45
Project Total  

This report was generated by python-coverage-comment-action

IFenton
IFenton approved these changes Aug 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@IFenton IFenton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jemrobinson jemrobinson merged commit 16c1b51 into main Aug 8, 2025
3 checks passed
@jemrobinson jemrobinson deleted the fix-model-summary-table branch August 8, 2025 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@IFenton IFenton IFenton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jemrobinson @IFenton